Fix the existing repo update code path#96
Merged
twarit-waikar merged 2 commits intomasterfrom Feb 18, 2026
Merged
Conversation
added 2 commits
February 18, 2026 16:07
This reverts commit f7e205b. There is a difference between the following 2 commands - 1. ``` p4 changes -s "submitted" -r -m 2 '//...@>CL_NUMBER' # Counts from CL_NUMBER ``` 2. ``` p4 changes -s "submitted" -m 2 '//...@>CL_NUMBER' # Count from the latest change ```
|
Thanks for the contribution! Unfortunately we can't verify the commit author(s): Twarit Waikar <t***@s***.com>. One possible solution is to add that email to your GitHub account. Alternatively you can change your commits to another email and force push the change. After getting your commits associated with your GitHub account, refresh the status of this Pull Request. |
| git_signature* author = nullptr; | ||
| GIT2(git_signature_new(&author, user.c_str(), email.c_str(), timestamp, timezone)); | ||
|
|
||
| STDHelpers::StripSurrounding(desc, '\n'); |
There was a problem hiding this comment.
Bad logic for trimming whitespace. This assumes the whitespace always appears in pairs at the beginning and the end of the message
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Also some minor build fixes